diff -r 42f013173f48 Lib/test/test_wave.py --- a/Lib/test/test_wave.py Thu Oct 17 19:34:12 2013 -0700 +++ b/Lib/test/test_wave.py Fri Oct 18 10:03:55 2013 +0300 @@ -49,9 +49,6 @@ frames = audiotests.byteswap2(frames) -@unittest.skipIf(sys.byteorder == 'big', - '24-bit wave files are supported only on little-endian ' - 'platforms') class WavePCM24Test(audiotests.AudioWriteTests, audiotests.AudioTestsWithSourceFile, unittest.TestCase): diff -r 42f013173f48 Lib/wave.py --- a/Lib/wave.py Thu Oct 17 19:34:12 2013 -0700 +++ b/Lib/wave.py Fri Oct 18 10:03:55 2013 +0300 @@ -87,6 +87,12 @@ from chunk import Chunk from collections import namedtuple +def _byteswap3(data): + ba = bytearray(data) + ba[::3] = data[2::3] + ba[2::3] = data[::3] + return bytes(ba) + _wave_params = namedtuple('_wave_params', 'nchannels sampwidth framerate nframes comptype compname') @@ -237,7 +243,7 @@ self._data_seek_needed = 0 if nframes == 0: return b'' - if self._sampwidth > 1 and sys.byteorder == 'big': + if self._sampwidth in (2, 4) and sys.byteorder == 'big': # unfortunately the fromfile() method does not take # something that only looks like a file object, so # we have to reach into the innards of the chunk object @@ -258,6 +264,8 @@ data = data.tobytes() else: data = self._data_chunk.read(nframes * self._framesize) + if self._sampwidth == 3 and sys.byteorder == 'big': + data = _byteswap3(data) if self._convert and data: data = self._convert(data) self._soundpos = self._soundpos + len(data) // (self._nchannels * self._sampwidth) @@ -439,6 +447,8 @@ data.tofile(self._file) self._datawritten = self._datawritten + len(data) * self._sampwidth else: + if self._sampwidth == 3 and sys.byteorder == 'big': + data = _byteswap3(data) self._file.write(data) self._datawritten = self._datawritten + len(data) self._nframeswritten = self._nframeswritten + nframes