diff -r a1c8c79e035d Modules/_csv.c --- a/Modules/_csv.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/_csv.c Thu Aug 09 18:18:21 2012 +0300 @@ -196,8 +196,12 @@ { if (src == NULL) *target = dflt; - else - *target = PyObject_IsTrue(src); + else { + int b = PyObject_IsTrue(src); + if (b < 0) + return -1; + *target = b; + } return 0; } diff -r a1c8c79e035d Modules/_io/textio.c --- a/Modules/_io/textio.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/_io/textio.c Thu Aug 09 18:18:21 2012 +0300 @@ -1056,8 +1056,11 @@ res = _PyObject_CallMethodId(buffer, &PyId_seekable, NULL); if (res == NULL) goto error; - self->seekable = self->telling = PyObject_IsTrue(res); + r = PyObject_IsTrue(res); Py_DECREF(res); + if (r < 0) + goto error; + self->seekable = self->telling = r; self->has_read1 = _PyObject_HasAttrId(buffer, &PyId_read1); diff -r a1c8c79e035d Modules/_posixsubprocess.c --- a/Modules/_posixsubprocess.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/_posixsubprocess.c Thu Aug 09 18:18:21 2012 +0300 @@ -503,7 +503,7 @@ subprocess_fork_exec(PyObject* self, PyObject *args) { PyObject *gc_module = NULL; - PyObject *executable_list, *py_close_fds, *py_fds_to_keep; + PyObject *executable_list, *py_fds_to_keep; PyObject *env_list, *preexec_fn; PyObject *process_args, *converted_args = NULL, *fast_args = NULL; PyObject *preexec_fn_args_tuple = NULL; @@ -518,15 +518,14 @@ Py_ssize_t arg_num; if (!PyArg_ParseTuple( - args, "OOOOOOiiiiiiiiiiO:fork_exec", - &process_args, &executable_list, &py_close_fds, &py_fds_to_keep, + args, "OOpOOOiiiiiiiiiiO:fork_exec", + &process_args, &executable_list, &close_fds, &py_fds_to_keep, &cwd_obj, &env_list, &p2cread, &p2cwrite, &c2pread, &c2pwrite, &errread, &errwrite, &errpipe_read, &errpipe_write, &restore_signals, &call_setsid, &preexec_fn)) return NULL; - close_fds = PyObject_IsTrue(py_close_fds); if (close_fds && errpipe_write < 3) { /* precondition */ PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3"); return NULL; diff -r a1c8c79e035d Modules/_ssl.c --- a/Modules/_ssl.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/_ssl.c Thu Aug 09 18:18:21 2012 +0300 @@ -1037,15 +1037,15 @@ PyObject *retval = NULL; int len; int verification; - PyObject *binary_mode = Py_None; + int binary_mode = 0; - if (!PyArg_ParseTuple(args, "|O:peer_certificate", &binary_mode)) + if (!PyArg_ParseTuple(args, "|p:peer_certificate", &binary_mode)) return NULL; if (!self->peer_cert) Py_RETURN_NONE; - if (PyObject_IsTrue(binary_mode)) { + if (binary_mode) { /* return cert in DER-encoded format */ unsigned char *bytes_buf = NULL; diff -r a1c8c79e035d Modules/itertoolsmodule.c --- a/Modules/itertoolsmodule.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/itertoolsmodule.c Thu Aug 09 18:18:21 2012 +0300 @@ -1105,11 +1105,13 @@ } ok = PyObject_IsTrue(good); Py_DECREF(good); - if (!ok) { + if (ok == 0) { lz->start = 1; return item; } Py_DECREF(item); + if (ok < 0) + return NULL; } } @@ -1124,7 +1126,7 @@ dropwhile_setstate(dropwhileobject *lz, PyObject *state) { int start = PyObject_IsTrue(state); - if (start == -1) + if (start < 0) return NULL; lz->start = start; Py_RETURN_NONE; @@ -1270,10 +1272,11 @@ } ok = PyObject_IsTrue(good); Py_DECREF(good); - if (ok) + if (ok == 1) return item; Py_DECREF(item); - lz->stop = 1; + if (ok == 0) + lz->stop = 1; return NULL; } @@ -1288,7 +1291,7 @@ takewhile_reduce_setstate(takewhileobject *lz, PyObject *state) { int stop = PyObject_IsTrue(state); - if (stop == -1) + if (stop < 0) return NULL; lz->stop = stop; Py_RETURN_NONE; @@ -3536,7 +3539,7 @@ if (ok == 1) return datum; Py_DECREF(datum); - if (ok == -1) + if (ok < 0) return NULL; } } @@ -3692,9 +3695,11 @@ ok = PyObject_IsTrue(good); Py_DECREF(good); } - if (!ok) + if (ok == 0) return item; Py_DECREF(item); + if (ok < 0) + return NULL; } } diff -r a1c8c79e035d Modules/parsermodule.c --- a/Modules/parsermodule.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/parsermodule.c Thu Aug 09 18:18:21 2012 +0300 @@ -382,36 +382,28 @@ static PyObject* parser_st2tuple(PyST_Object *self, PyObject *args, PyObject *kw) { - PyObject *line_option = 0; - PyObject *col_option = 0; + int line_info = 0; + int col_info = 0; PyObject *res = 0; int ok; static char *keywords[] = {"st", "line_info", "col_info", NULL}; if (self == NULL || PyModule_Check(self)) { - ok = PyArg_ParseTupleAndKeywords(args, kw, "O!|OO:st2tuple", keywords, - &PyST_Type, &self, &line_option, - &col_option); + ok = PyArg_ParseTupleAndKeywords(args, kw, "O!|pp:st2tuple", keywords, + &PyST_Type, &self, &line_info, + &col_info); } else - ok = PyArg_ParseTupleAndKeywords(args, kw, "|OO:totuple", &keywords[1], - &line_option, &col_option); + ok = PyArg_ParseTupleAndKeywords(args, kw, "|pp:totuple", &keywords[1], + &line_info, &col_info); if (ok != 0) { - int lineno = 0; - int col_offset = 0; - if (line_option != NULL) { - lineno = (PyObject_IsTrue(line_option) != 0) ? 1 : 0; - } - if (col_option != NULL) { - col_offset = (PyObject_IsTrue(col_option) != 0) ? 1 : 0; - } /* * Convert ST into a tuple representation. Use Guido's function, * since it's known to work already. */ res = node2tuple(((PyST_Object*)self)->st_node, - PyTuple_New, PyTuple_SetItem, lineno, col_offset); + PyTuple_New, PyTuple_SetItem, line_info, col_info); } return (res); } @@ -426,35 +418,27 @@ static PyObject* parser_st2list(PyST_Object *self, PyObject *args, PyObject *kw) { - PyObject *line_option = 0; - PyObject *col_option = 0; + int line_info = 0; + int col_info = 0; PyObject *res = 0; int ok; static char *keywords[] = {"st", "line_info", "col_info", NULL}; if (self == NULL || PyModule_Check(self)) - ok = PyArg_ParseTupleAndKeywords(args, kw, "O!|OO:st2list", keywords, - &PyST_Type, &self, &line_option, - &col_option); + ok = PyArg_ParseTupleAndKeywords(args, kw, "O!|pp:st2list", keywords, + &PyST_Type, &self, &line_info, + &col_info); else - ok = PyArg_ParseTupleAndKeywords(args, kw, "|OO:tolist", &keywords[1], - &line_option, &col_option); + ok = PyArg_ParseTupleAndKeywords(args, kw, "|pp:tolist", &keywords[1], + &line_info, &col_info); if (ok) { - int lineno = 0; - int col_offset = 0; - if (line_option != 0) { - lineno = PyObject_IsTrue(line_option) ? 1 : 0; - } - if (col_option != NULL) { - col_offset = (PyObject_IsTrue(col_option) != 0) ? 1 : 0; - } /* * Convert ST into a tuple representation. Use Guido's function, * since it's known to work already. */ res = node2tuple(self->st_node, - PyList_New, PyList_SetItem, lineno, col_offset); + PyList_New, PyList_SetItem, line_info, col_info); } return (res); } diff -r a1c8c79e035d Modules/pyexpat.c --- a/Modules/pyexpat.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Modules/pyexpat.c Thu Aug 09 18:18:21 2012 +0300 @@ -1038,8 +1038,12 @@ enum XML_Error rc; if (!PyArg_UnpackTuple(args, "UseForeignDTD", 0, 1, &flagobj)) return NULL; - if (flagobj != NULL) - flag = PyObject_IsTrue(flagobj) ? XML_TRUE : XML_FALSE; + if (flagobj != NULL) { + int b = PyObject_IsTrue(flagobj); + if (b < 0) + return NULL; + flag = b ? XML_TRUE : XML_FALSE; + } rc = XML_UseForeignDTD(self->itself, flag); if (rc != XML_ERROR_NONE) { return set_error(self, rc); @@ -1405,7 +1409,10 @@ } assert(PyUnicode_Check(name)); if (PyUnicode_CompareWithASCIIString(name, "buffer_text") == 0) { - if (PyObject_IsTrue(v)) { + int b = PyObject_IsTrue(v); + if (b < 0) + return -1; + if (b) { if (self->buffer == NULL) { self->buffer = malloc(self->buffer_size); if (self->buffer == NULL) { @@ -1424,25 +1431,25 @@ return 0; } if (PyUnicode_CompareWithASCIIString(name, "namespace_prefixes") == 0) { - if (PyObject_IsTrue(v)) - self->ns_prefixes = 1; - else - self->ns_prefixes = 0; + int b = PyObject_IsTrue(v); + if (b < 0) + return -1; + self->ns_prefixes = b; XML_SetReturnNSTriplet(self->itself, self->ns_prefixes); return 0; } if (PyUnicode_CompareWithASCIIString(name, "ordered_attributes") == 0) { - if (PyObject_IsTrue(v)) - self->ordered_attributes = 1; - else - self->ordered_attributes = 0; + int b = PyObject_IsTrue(v); + if (b < 0) + return -1; + self->ordered_attributes = b; return 0; } if (PyUnicode_CompareWithASCIIString(name, "specified_attributes") == 0) { - if (PyObject_IsTrue(v)) - self->specified_attributes = 1; - else - self->specified_attributes = 0; + int b = PyObject_IsTrue(v); + if (b < 0) + return -1; + self->specified_attributes = b; return 0; } diff -r a1c8c79e035d Objects/typeobject.c --- a/Objects/typeobject.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Objects/typeobject.c Thu Aug 09 18:18:21 2012 +0300 @@ -396,12 +396,16 @@ } if (res == 0) { PyType_Modified(type); - if (value && PyObject_IsTrue(value)) { - type->tp_flags |= Py_TPFLAGS_IS_ABSTRACT; + if (value) { + int b = PyObject_IsTrue(value); + if (b < 0) + return -1; + if (b) { + type->tp_flags |= Py_TPFLAGS_IS_ABSTRACT; + return res; + } } - else { - type->tp_flags &= ~Py_TPFLAGS_IS_ABSTRACT; - } + type->tp_flags &= ~Py_TPFLAGS_IS_ABSTRACT; } return res; } diff -r a1c8c79e035d Python/bltinmodule.c --- a/Python/bltinmodule.c Wed Aug 08 21:03:02 2012 -0700 +++ b/Python/bltinmodule.c Thu Aug 09 18:18:21 2012 +0300 @@ -429,9 +429,11 @@ ok = PyObject_IsTrue(good); Py_DECREF(good); } - if (ok) + if (ok > 0) return item; Py_DECREF(item); + if (ok < 0) + return NULL; } }