Index: Lib/ssl.py =================================================================== --- Lib/ssl.py (révision 80312) +++ Lib/ssl.py (copie de travail) @@ -114,12 +114,7 @@ cert_reqs, ssl_version, ca_certs, ciphers) if do_handshake_on_connect: - timeout = self.gettimeout() - try: - self.settimeout(None) - self.do_handshake() - finally: - self.settimeout(timeout) + self.do_handshake() self.keyfile = keyfile self.certfile = certfile self.cert_reqs = cert_reqs Index: Lib/test/test_ssl.py =================================================================== --- Lib/test/test_ssl.py (révision 80312) +++ Lib/test/test_ssl.py (copie de travail) @@ -440,7 +440,8 @@ asyncore.dispatcher_with_send.__init__(self, conn) self.socket = ssl.wrap_socket(conn, server_side=True, certfile=certfile, - do_handshake_on_connect=True) + do_handshake_on_connect=False) + self._ssl_accepting = True def readable(self): if isinstance(self.socket, ssl.SSLSocket): @@ -448,9 +449,28 @@ self.handle_read_event() return True + def _do_ssl_handshake(self): + try: + self.socket.do_handshake() + except ssl.SSLError, err: + if err.args[0] in (ssl.SSL_ERROR_WANT_READ, + ssl.SSL_ERROR_WANT_WRITE): + return + elif err.args[0] == ssl.SSL_ERROR_EOF: + return self.handle_close() + raise + except socket.error, err: + if err.args[0] == errno.ECONNABORTED: + return self.handle_close() + else: + self._ssl_accepting = False + def handle_read(self): - data = self.recv(1024) - self.send(data.lower()) + if self._ssl_accepting: + self._do_ssl_handshake() + else: + data = self.recv(1024) + self.send(data.lower()) def handle_close(self): self.close() @@ -1216,8 +1236,54 @@ finally: server.stop() server.join() + + def test_handshake_timeout(self): + server = socket.socket(socket.AF_INET) + host = "127.0.0.1" + port = test_support.bind_port(server) + started = threading.Event() + finish = False + def serve(): + server.listen(5) + started.set() + conns = [] + while not finish: + r, w, e = select.select([server], [], [], 0.1) + if server in r: + # Let the socket hang around rather than having + # it closed by garbage collection. + conns.append(server.accept()[0]) + t = threading.Thread(target=serve) + t.start() + started.wait() + + try: + try: + c = socket.socket(socket.AF_INET) + c.settimeout(0.2) + c.connect((host, port)) + # Will attempt handshake and time out + self.assertRaisesRegexp(ssl.SSLError, "timed out", + ssl.wrap_socket, c) + finally: + c.close() + try: + c = socket.socket(socket.AF_INET) + c.settimeout(0.2) + c = ssl.wrap_socket(c) + # Will attempt handshake and time out + self.assertRaisesRegexp(ssl.SSLError, "timed out", + c.connect, (host, port)) + finally: + c.close() + finally: + finish = True + t.join() + server.close() + + def test_main(verbose=False): if skip_expected: raise unittest.SkipTest("No SSL support") Index: Modules/_ssl.c =================================================================== --- Modules/_ssl.c (révision 80312) +++ Modules/_ssl.c (copie de travail) @@ -451,8 +451,13 @@ { int ret; int err; - int sockstate; + int sockstate, nonblocking; + /* just in case the blocking state of the socket has been changed */ + nonblocking = (self->Socket->sock_timeout >= 0.0); + BIO_set_nbio(SSL_get_rbio(self->ssl), nonblocking); + BIO_set_nbio(SSL_get_wbio(self->ssl), nonblocking); + /* Actually negotiate SSL connection */ /* XXX If SSL_do_handshake() returns 0, it's also a failure. */ sockstate = 0;