Index: Lib/urllib/parse.py =================================================================== --- Lib/urllib/parse.py (revision 80148) +++ Lib/urllib/parse.py (working copy) @@ -95,8 +95,6 @@ netloc = self.netloc.split('@')[-1] if '[' in netloc and ']' in netloc: return netloc.split(']')[0][1:].lower() - elif '[' in netloc or ']' in netloc: - raise ValueError("Invalid IPv6 hostname") elif ':' in netloc: return netloc.split(':')[0].lower() elif netloc == '': @@ -156,10 +154,6 @@ def _splitnetloc(url, start=0): delim = len(url) # position of end of domain part of url, default is end - if '[' in url: # check for invalid IPv6 URL - if not ']' in url: raise ValueError("Invalid IPv6 URL") - elif ']' in url: - if not '[' in url: raise ValueError("Invalid IPv6 URL") for c in '/?#': # look for delimiters; the order is NOT important wdelim = url.find(c, start) # find first of this delim if wdelim >= 0: # if found @@ -187,6 +181,10 @@ url = url[i+1:] if url[:2] == '//': netloc, url = _splitnetloc(url, 2) + if '[' in netloc : + if not ']' in netloc: raise ValueError("Invalid IPv6 URL") + if ']' in netloc: + if not '[' in netloc: raise ValueError("Invalid IPv6 URL") if allow_fragments and '#' in url: url, fragment = url.split('#', 1) if '?' in url: @@ -201,6 +199,10 @@ scheme, url = url[:i].lower(), url[i+1:] if url[:2] == '//': netloc, url = _splitnetloc(url, 2) + if '[' in netloc: + if not ']' in netloc: raise ValueError("Invalid IPv6 URL") + if ']' in netloc: + if not '[' in netloc: raise ValueError("Invalid IPv6 URL") if allow_fragments and scheme in uses_fragment and '#' in url: url, fragment = url.split('#', 1) if scheme in uses_query and '?' in url: Index: Lib/test/test_urlparse.py =================================================================== --- Lib/test/test_urlparse.py (revision 80147) +++ Lib/test/test_urlparse.py (working copy) @@ -273,6 +273,7 @@ for invalid_url in [ 'http://::12.34.56.78]/', 'http://[::1/foo/', + 'http://[::1/foo/bad]/bad', 'http://[::ffff:12.34.56.78']: self.assertRaises(ValueError, lambda : urllib.parse.urlparse(invalid_url).hostname) self.assertRaises(ValueError, lambda : urllib.parse.urlparse(invalid_url))