Index: Lib/wave.py =================================================================== --- Lib/wave.py (revision 74246) +++ Lib/wave.py (working copy) @@ -355,7 +355,7 @@ raise Error('cannot change parameters after starting to write') if framerate <= 0: raise Error('bad frame rate') - self._framerate = framerate + self._framerate = int(round(framerate)) def getframerate(self): if not self._framerate: Index: Lib/test/test_wave.py =================================================================== --- Lib/test/test_wave.py (revision 74246) +++ Lib/test/test_wave.py (working copy) @@ -21,11 +21,14 @@ except OSError: pass - def test_it(self): + def test_it(self, test_rounding=False): self.f = wave.open(TESTFN, 'wb') self.f.setnchannels(nchannels) self.f.setsampwidth(sampwidth) - self.f.setframerate(framerate) + if test_rounding: + self.f.setframerate(framerate - 0.1) + else: + self.f.setframerate(framerate) self.f.setnframes(nframes) output = b'\0' * nframes * nchannels * sampwidth self.f.writeframes(output) @@ -38,6 +41,13 @@ self.assertEqual(nframes, self.f.getnframes()) self.assertEqual(self.f.readframes(nframes), output) + def test_fractional_framerate(self): + """ + Addresses [ 1512791 ] module wave does no rounding + Floating point framerates should be rounded, rather than truncated. + """ + self.test_it(test_rounding=True) + def test_main(): run_unittest(TestWave)