Index: Objects/setobject.c =================================================================== --- Objects/setobject.c (revision 66830) +++ Objects/setobject.c (working copy) @@ -1861,7 +1861,7 @@ static PyObject * set_remove(PySetObject *so, PyObject *key) { - PyObject *tmpkey, *result; + PyObject *tmpkey; int rv; rv = set_discard_key(so, key); @@ -1873,11 +1873,14 @@ if (tmpkey == NULL) return NULL; set_swap_bodies((PySetObject *)tmpkey, (PySetObject *)key); - result = set_remove(so, tmpkey); + rv = set_discard_key(so, tmpkey); set_swap_bodies((PySetObject *)tmpkey, (PySetObject *)key); Py_DECREF(tmpkey); - return result; - } else if (rv == DISCARD_NOTFOUND) { + if (rv == -1) + return NULL; + } + + if (rv == DISCARD_NOTFOUND) { set_key_error(key); return NULL; } Index: Lib/test/test_set.py =================================================================== --- Lib/test/test_set.py (revision 66830) +++ Lib/test/test_set.py (working copy) @@ -391,6 +391,17 @@ else: self.fail() + def test_remove_keyerror_set(self): + key = self.thetype([3, 4]) + try: + self.s.remove(key) + except KeyError as e: + self.assert_(e.args[0] is key, + "KeyError should be {0}, not {1}".format(key, + e.args[0])) + else: + self.fail() + def test_discard(self): self.s.discard('a') self.assert_('a' not in self.s)