Index: Lib/csv.py =================================================================== --- Lib/csv.py (revision 65340) +++ Lib/csv.py (working copy) @@ -71,7 +71,7 @@ class DictReader: def __init__(self, f, fieldnames=None, restkey=None, restval=None, dialect="excel", *args, **kwds): - self.fieldnames = fieldnames # list of keys for the dict + self._fieldnames = fieldnames # list of keys for the dict self.restkey = restkey # key to catch long rows self.restval = restval # default value for short rows self.reader = reader(f, dialect, *args, **kwds) @@ -81,11 +81,25 @@ def __iter__(self): return self + @property + def fieldnames(self): + if self._fieldnames is None: + try: + self._fieldnames = self.reader.next() + except StopIteration: + pass + self.line_num = self.reader.line_num + return self._fieldnames + + @fieldnames.setter + def fieldnames(self, value): + self._fieldnames = value + def next(self): + if self.line_num == 0: + # Used only for its side effect. + self.fieldnames row = self.reader.next() - if self.fieldnames is None: - self.fieldnames = row - row = self.reader.next() self.line_num = self.reader.line_num # unlike the basic reader, we prefer not to return blanks, Index: Lib/test/test_csv.py =================================================================== --- Lib/test/test_csv.py (revision 65340) +++ Lib/test/test_csv.py (working copy) @@ -611,11 +611,43 @@ fileobj.write("f1,f2,f3\r\n1,2,abc\r\n") fileobj.seek(0) reader = csv.DictReader(fileobj) + self.assertEqual(reader.fieldnames, ["f1", "f2", "f3"]) self.assertEqual(reader.next(), {"f1": '1', "f2": '2', "f3": 'abc'}) finally: fileobj.close() os.unlink(name) + # Two test cases to make sure existing ways of implicitly setting + # fieldnames continue to work. Both arise from discussion in issue3436. + def test_read_dict_fieldnames_from_file(self): + fd, name = tempfile.mkstemp() + f = os.fdopen(fd, "w+b") + try: + f.write("f1,f2,f3\r\n1,2,abc\r\n") + f.seek(0) + reader = csv.DictReader(f, fieldnames=csv.reader(f).next()) + self.assertEqual(reader.fieldnames, ["f1", "f2", "f3"]) + self.assertEqual(reader.next(), {"f1": '1', "f2": '2', "f3": 'abc'}) + finally: + f.close() + os.unlink(name) + + def test_read_dict_fieldnames_chain(self): + import itertools + fd, name = tempfile.mkstemp() + f = os.fdopen(fd, "w+b") + try: + f.write("f1,f2,f3\r\n1,2,abc\r\n") + f.seek(0) + reader = csv.DictReader(f) + first = next(reader) + for row in itertools.chain([first], reader): + self.assertEqual(reader.fieldnames, ["f1", "f2", "f3"]) + self.assertEqual(row, {"f1": '1', "f2": '2', "f3": 'abc'}) + finally: + f.close() + os.unlink(name) + def test_read_long(self): fd, name = tempfile.mkstemp() fileobj = os.fdopen(fd, "w+b") @@ -651,6 +683,7 @@ fileobj.write("f1,f2\r\n1,2,abc,4,5,6\r\n") fileobj.seek(0) reader = csv.DictReader(fileobj, restkey="_rest") + self.assertEqual(reader.fieldnames, ["f1", "f2"]) self.assertEqual(reader.next(), {"f1": '1', "f2": '2', "_rest": ["abc", "4", "5", "6"]}) finally: